Support phrases replacement #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fcitx5-mcbopomofo, phrases replacement is enabled if `phrases-replacement.txt` exists in the user's data path, usually `$HOME/.local/share/fcitx5/mcbopomofo/phrases-replacement.txt`, and it's disabled if the file does not exist or is removed. fcitx5-mcbopomofo does not populate the file with a template; this is different from the behavior of the macOS version.
zonble
approved these changes
Mar 29, 2024
|
Thanks!
Sounds good. Let me look into, as a follow-up to this, adding a menu item when phrases replacement is enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fcitx5-mcbopomofo, phrases replacement is enabled if
phrases-replacement.txtexists in the user's data path, usually$HOME/.local/share/fcitx5/mcbopomofo/phrases-replacement.txt, and it's disabled if the file does not exist or is removed.fcitx5-mcbopomofo does not populate the file with a template; this is different from the behavior of the macOS version.
This feature is introduced to be in sync with the macOS version. It's also motivated by openvanilla/McBopomofo#458, which can be solved by phrases replacement.