Add all missing libpostal_ exports to .def #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batterseapower
added a commit
to batterseapower/pypostal
that referenced
this pull request
Oct 13, 2018
Note that this will only work once openvenues/libpostal#376 is merged to libpostal.
|
what's blocking here? |
AeroXuk
approved these changes
May 13, 2019
AeroXuk
added a commit
to AeroXuk/libpostal
that referenced
this pull request
Jan 18, 2020
Add all missing libpostal_ exports to .def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, openvenues/pypostal can't link to the DLL that the libpostal Windows build creates. pypostal seems to use most of these functions: rather than figure out exactly which ones were necessary, I just added all the current exports of the DLL.