Fix another ssl context leak #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterjm
approved these changes
Mar 27, 2023
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
Mar 27, 2023
release is pending fixes #83524 fixes #45513 fixes #85902 changes openvideolibs/python-onvif-zeep-async#11 openvideolibs/python-onvif-zeep-async#12
20 tasks
bdraco
added a commit
that referenced
this pull request
Apr 14, 2023
Since zeep will create a wsdl_client with an ssl context even if we never use it, we can avoid the additional context creation by passing in our own httpx.Client This is an alternate solution for #11 which should have less side effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncTransport creates a wdsl sync client even if its never used which generates yet another ssl context.
I had trouble with reaching the max connections when each service had a separate connection pool which would result in requests failing. Now all services (except snapshots) now use the same connection pool/client which avoids the need to close/create clients over and over. There is still a separate client created per camera.
I picked up the cameras that seemed to have the most issues + the annke (which doesn't) and tested with:
TAPO C320WS
TAPO C110
REOLINK E1 PLUS
LC IPC-TA42-D
SV3C HX SERIES
ANNKE I51DM