Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortened common onvif namespace prefixes #54

Merged
merged 9 commits into from
Dec 3, 2024

Conversation

jterrace
Copy link

This fixes some Tapo cameras that respond with a 500 error when receiving the ns0/ns1 namespace prefix with embedded xmlns definitions inside each element.

A similar change was done upstream here:
FalkTannhaeuser/python-onvif-zeep#46

for mvantellingen/python-zeep#870.

This fixes the main barrier for getting JurajNyiri/HomeAssistant-Tapo-Control#304 fixed.

I also updated the events example that was broken.

This fixes some Tapo cameras that respond with a 500 error when
receiving the ns0/ns1 namespace prefix with embedded xmlns definitions
inside each element.

A similar change was done upstream here:
FalkTannhaeuser/python-onvif-zeep#46

for mvantellingen/python-zeep#870.

I also updated the events example that was broken.
@bdraco
Copy link
Member

bdraco commented Nov 22, 2024

I can take a look the week after Thanksgiving

@bdraco bdraco changed the title Add shortened common onvif namespace prefixes. Add shortened common onvif namespace prefixes Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
onvif/client.py 53.62% <100.00%> (+0.54%) ⬆️

@bdraco bdraco merged commit 3a06809 into openvideolibs:async Dec 3, 2024
6 checks passed
@bdraco
Copy link
Member

bdraco commented Dec 3, 2024

Tested with a few random ONVIF cameras and didn't observe any regressions

@jterrace
Copy link
Author

jterrace commented Dec 3, 2024

Thanks, Nick!

@bdraco
Copy link
Member

bdraco commented Dec 3, 2024

3.1.13 published

@bdraco
Copy link
Member

bdraco commented Dec 3, 2024

I didn't do a dep update PR to home-assistant/core as I ran out of time getting after getting the CI/codecov/publishing working on this repo. If someone could do that, it would be appreciated.

@jterrace
Copy link
Author

jterrace commented Dec 3, 2024

I'm going to update home-assistant/core#130769 to include the version bump.

@bdraco
Copy link
Member

bdraco commented Dec 3, 2024

@jterrace
Copy link
Author

jterrace commented Dec 3, 2024

Okay, will leave it alone then and submit a separate PR

@jterrace jterrace deleted the tapo-500 branch December 4, 2024 01:46
@bdraco
Copy link
Member

bdraco commented Dec 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants