-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit
issues caused by the EfficientAD PR
#1114
Fix pre-commit
issues caused by the EfficientAD PR
#1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you enjoy the pr and correct another issue? If you try to run it with an image size smaller than 256 (i guess, i tried 224) it breaks because at some point in the model there will be a convolutional kernel (8x8) size bigger than the feature map resolution (7x7). I think just an assertion at the init would do (to explicitly let the user know this). |
Description
Fixes
Changes
Checklist