Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit issues caused by the EfficientAD PR #1114

Merged
merged 23 commits into from
Jun 13, 2023

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Jun 7, 2023

Description

  • This is to fix the pre-commit issues caused by the efficient ad pr

Fixes

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@samet-akcay samet-akcay requested a review from djdameln June 7, 2023 10:56
@github-actions github-actions bot removed the Tests label Jun 9, 2023
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpcbertoldo
Copy link
Contributor

jpcbertoldo commented Jun 13, 2023

Could you enjoy the pr and correct another issue?

If you try to run it with an image size smaller than 256 (i guess, i tried 224) it breaks because at some point in the model there will be a convolutional kernel (8x8) size bigger than the feature map resolution (7x7).

I think just an assertion at the init would do (to explicitly let the user know this).

@samet-akcay samet-akcay merged commit 4b45f05 into openvinotoolkit:main Jun 13, 2023
@samet-akcay samet-akcay mentioned this pull request Jun 15, 2023
@samet-akcay samet-akcay deleted the fix/pre-commit branch October 7, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants