-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ensembling methods for tiling to Anomalib #1226
Conversation
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
@blaz-r the pre-commit checks are failing due to some comments left out in the code. Would you want to address them. I will need to merge this PR this week, as I would like this to be part of 1.2, which I plan to release next week. |
Okay, I'll handle the remaining things in a few hours. |
Great, thanks! |
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
The issues should now be resolved. |
Thanks @blaz-r, I've just triggered the CI |
It's failing on tiled ensemble "predict" pipeline integration test, that is executed after "train" pipeline. I'm not sure why, but it looks like the weight file is not found. Could be due to file name, but I don't know how to debug this, as it works fine locally (of course 😅 ) |
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
I believe the problem is in file path case (since windows is case insensitive 🙄). I changed that now. |
Eh, still not quite okay. Let me sort this locally on WSL. |
Signed-off-by: blaz-r <blaz.rolih@gmail.com>
Okay, I think it is now resolved (at least for me on both Windows and WSL ubuntu). For some reason, temporary directory behaves differently on the Linux, but I solved that by using the existing "project_path" fixture, and it seems to work alright now. |
It looks like it's still failing due to file not found. I'm really not sure why that is happening at this point. The weight file works just fine on my end, both in Windows and Linux. It might be possible that there's an error with the temporary directory, or the file name, but I'm not sure how to debug that inside actions. |
It could be a problem of case, since mvtec path could be named "MVTec", but looking at other tests they use small case as well. In any case, it works just fine on Ubuntu for me. I can change it to "MVTec" and we run again, or if you have any other ideas how to resolve this. |
Signed-off-by: Blaz Rolih <blaz.rolih@gmail.com>
@blaz-r it's all green! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for the huge effort!
Great 😄 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this very nice implementation! This is a great example of how the pipelines API can be used to achieve complex custom workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the massive efforts!
Merging now. Thanks again! |
Description
This PR adds mechanism to train ensemble of models on tiled images. It is part of Google Summer of Code.
Implementation Details:
Closes:
Changes
Checklist
Some things still todo (tests, docs...) but most of the code is ready for review.