Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DRAEM #1431
Fix DRAEM #1431
Changes from all commits
8783ab6
d5f46dd
4502d4f
5d96b02
94a694c
d514c31
a5ae7b6
6c11f00
4351a37
e1bd664
5f0888d
78f0cb8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously did not add this because early stopping is enabled, and the training rarely reaches 400 epochs. But since we recently decided to always use the configuration recommended in the paper as the default, I agree it would be good to add it now.
In this case we should probably also disable early stopping by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a few training runs I did, the last few epochs make a little difference, but it is noticeable. With current design, removing early stopping would also require changing of this function:
anomalib/src/anomalib/models/draem/lightning_model.py
Lines 132 to 146 in 66532fc
Should I then remove it from config and also add an if statement here to check if it's present or should it be removed altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the user should have the possibility to enable early stopping if they want to, so let's add a check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is now implemented.