Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Add default metrics to Engine #1769

Conversation

samet-akcay
Copy link
Contributor

📝 Description

  • Metric values in Engine is currently None. When Engine is used with default values, the validation step is not run since there is no metric. Due to this there is no test results. This PR adds AUROC and F1Score as the default metrics to both image and pixel level metrics.
  • 🛠️ Fixes 🔨 Add default metric values to Engine #1747

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks just one question

src/anomalib/engine/engine.py Outdated Show resolved Hide resolved
@ashwinvaidya17
Copy link
Collaborator

I see that some tests are failing as they directly access pixel_metric_names

@github-actions github-actions bot added the Tests label Feb 26, 2024
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashwinvaidya17 ashwinvaidya17 merged commit 3b3395e into openvinotoolkit:main Feb 27, 2024
7 checks passed
@samet-akcay samet-akcay deleted the refactor/add-default-metrics-to-engine branch February 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 Add default metric values to Engine
2 participants