-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Refactor Engine.predict
method
#1772
🔨 Refactor Engine.predict
method
#1772
Conversation
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to make the same changes for the other entrypoints? In the following for example,
def fit(
self,
model: AnomalyModule,
train_dataloaders: TRAIN_DATALOADERS | AnomalibDataModule | None = None,
val_dataloaders: EVAL_DATALOADERS | None = None,
datamodule: AnomalibDataModule | None = None,
ckpt_path: str | None = None,
) -> None:
it would be more consistent if train_dataloaders
is only allowed to be a (list of) dataloader(s)
Ah good point! I'll update those as well |
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
📝 Description
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.