🚀 Add HPO #2188
🚀 Add HPO #2188
Conversation
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
|
|
||
|
|
||
| @dataclass | ||
| class ParserConfig: |
There was a problem hiding this comment.
Not sure if I fully understand this object. Is it parsing objects? or storing them in one dataclass?
|
|
||
| Args: | ||
| project (str): The project name. | ||
| entity (str | None): The entity or team name that is associated with the backend account. |
There was a problem hiding this comment.
Is entity what comet uses as an argument as well?
| logger: "Logger" | ||
|
|
||
|
|
||
| class CometParser: |
There was a problem hiding this comment.
If I follow the description in the docstring, would it be an idea to name this class as CometConfigParser?
| return CometParser(project=self.project, entity=self.entity) | ||
| case HPOBackend.WANDB: | ||
| msg = "wandb backend is not supported yet." | ||
| raise ValueError(msg) |
There was a problem hiding this comment.
would it be an idea to replace this with NotImplementedError
| ) -> Generator[HPOJob, None, None]: | ||
| """Return iterator based on the arguments.""" | ||
| del previous_stage_result # Not needed for this job | ||
| assert config is not None, "Config is required for HPOJobGenerator." |
There was a problem hiding this comment.
Would it be possible to raise an error instead. Ruff does not like assert statements in the codebase
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2188 +/- ##
==========================================
- Coverage 80.80% 80.48% -0.33%
==========================================
Files 248 255 +7
Lines 10859 11010 +151
==========================================
+ Hits 8775 8861 +86
- Misses 2084 2149 +65 ☔ View full report in Codecov by Sentry. |
📝 Description
TODO
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.