Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MissingAnnotationDetection transform #1049

Merged
merged 13 commits into from
Jun 23, 2023
Merged

Add MissingAnnotationDetection transform #1049

merged 13 commits into from
Jun 23, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jun 15, 2023 •
edited
Loading

Summary

  • Ticket no. 112206
  • Add MissingAnnotationDetection transform which extracts missing annotations from the model predictions

How to test

Added some tests for these changes.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Update to the latest OV API
19b79a5 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Make specs.json more interpretable
2429d46 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add missing src/datumaro/plugins/sampler/algorithm/__init__.py
d4d0bb7 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge branch 'hotfix/make-specs-more-interpretable' into bugfix/updat…
3c9783b 
…e-to-latest-ov-api

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge remote-tracking branch 'upstream/develop' into bugfix/update-to…
10ed762 
…-latest-ov-api

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Change ModelInterpreter logic
5005cfb 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Did some refactoring for OpenvinoLauncher and AnnotationMatchers
25a38e5 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add MissingLabelDetection transform
0bb6ee4 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Add MissingAnnotationTransform Add MissingAnnotationDetection transform Jun 15, 2023
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jun 15, 2023
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Jun 15, 2023
@vinnamkim
Update CHANGELOG.md
2157b70 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Merge remote-tracking branch 'upstream/develop' into feature/add-miss…
72a013c 
…ing-label-detection-transform

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review June 20, 2023 06:54
@vinnamkim vinnamkim requested review from a team as code owners June 20, 2023 06:54
@vinnamkim vinnamkim mentioned this pull request Jun 21, 2023
Merged
6 tasks
@vinnamkim
Fix
25a3817 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add assert
305822b 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
wonjuleee
wonjuleee previously approved these changes Jun 22, 2023
View reviewed changes
sooahleex
sooahleex previously approved these changes Jun 22, 2023
View reviewed changes
@vinnamkim vinnamkim dismissed stale reviews from sooahleex and wonjuleee via 3b32119 June 22, 2023 04:39
wonjuleee
wonjuleee approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit b1cdfd5 into openvinotoolkit:develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sooahleex sooahleex sooahleex approved these changes

@wonjuleee wonjuleee wonjuleee approved these changes

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@sstrehlk sstrehlk Awaiting requested review from sstrehlk sstrehlk is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
FEATURE New feature & functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnamkim @wonjuleee @sooahleex