-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misimplements for stream importer found while testing on the real-life COCO2017 object detection dataset #1093
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…ataset Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
- Specify encoding type (utf-8) Signed-off-by: Vinnam Kim <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…tream-importer-coco Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…m independence Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…aset Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…simplements-found-from-reallife-coco-stream-exp Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change all method to classmethod
to be used in COCOExtractorMerger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move some classes here to break the circular dependency
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
…allife-coco-stream-exp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how COCOExtractorMerger
is operated across tasks and what difference from the original ExtractorMerger
. Could you clarify this?
Let's assume we import
Both extractors have a dataset item (id=40), but different annotations (captions or polygons). |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Summary
is_stream
testStreamDataset.import_from(path, format="coco_instances")
actually createDataset
notStreamDataset
._CocoBase(stream=True)
can be obtained fromCOCOPageMapper
."categories"
section when it is at the end of JSON file._CocoBase(stream=False)
abruptly raising an error when the progress reporter is given.COCOExtractorMerger
to handle"coco"
import which should merge extractors across the tasks.How to test
I manually tested the following code on the real-life COCO2017 object detection dataset.
Results:
Checklist
License
Feel free to contact the maintainers if that's a concern.