-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust API to optimize COCOPageMapper performance #1120
Add Rust API to optimize COCOPageMapper performance #1120
Conversation
- Migrate COCOPageMapper algorithm from Python to Rust implementation Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1120 +/- ##
===========================================
- Coverage 80.00% 79.97% -0.04%
===========================================
Files 258 258
Lines 29329 29140 -189
Branches 5745 5709 -36
===========================================
- Hits 23465 23304 -161
+ Misses 4516 4506 -10
+ Partials 1348 1330 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This improvement shows that
How to test
Existing COCO tests with
stream=True
cover these changes.Checklist
License
Feel free to contact the maintainers if that's a concern.