Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison level-up doc #1174

Merged
merged 8 commits into from
Oct 23, 2023

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Oct 19, 2023

Summary

  • Add comparison level-up documentation
  • Update compare command documentation to add methods

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex added the DOC Improvements or additions to documentation label Oct 19, 2023
@sooahleex sooahleex marked this pull request as ready for review October 19, 2023 10:05
@sooahleex sooahleex requested review from a team as code owners October 19, 2023 10:05
@sooahleex sooahleex requested review from vinnamkim and removed request for a team October 19, 2023 10:05
@sooahleex sooahleex added this to the 1.5.1 milestone Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76d25c5) 79.94% compared to head (af8cf1c) 79.94%.

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.5.0    #1174   +/-   ##
===============================================
  Coverage           79.94%   79.94%           
===============================================
  Files                 264      264           
  Lines               29682    29682           
  Branches             5831     5831           
===============================================
  Hits                23728    23728           
  Misses               4621     4621           
  Partials             1333     1333           
Flag Coverage Δ
windows-2022_Python-3.8 79.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sooahleex sooahleex merged commit 19fb861 into openvinotoolkit:releases/1.5.0 Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants