-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Datumaro visualizer's import errors after introducing lazy import #1220
Fix Datumaro visualizer's import errors after introducing lazy import #1220
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1220 +/- ##
===========================================
+ Coverage 80.10% 80.44% +0.34%
===========================================
Files 269 269
Lines 29915 29913 -2
Branches 5850 5850
===========================================
+ Hits 23962 24064 +102
+ Misses 4617 4487 -130
- Partials 1336 1362 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you implement an optional showing of id and subset info in the visualizer too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<!-- Contributing guide: https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md --> ### Summary - Ticket no. 127587 - This option is needed for Datumaro GUI. See this comment, #1220 (review) ### How to test The existing unit test can cover `show_plot_title=True` option. `show_plot_title=False` is not covered, but manually tested. Please see this ![image](https://github.com/openvinotoolkit/datumaro/assets/26541465/be5f9c1f-d115-40a8-bac6-d91e16fc946f) It might be addressed in the future when we transition the `Visualizer` unit tests from the `unittest` to the `pytest` framework. ### Checklist <!-- Put an 'x' in all the boxes that apply --> - [ ] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [x] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly ### License - [x] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [x] I have updated the license header for each file (see an example below). ```python # Copyright (C) 2023 Intel Corporation # # SPDX-License-Identifier: MIT ``` --------- Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Summary
How to test
This Python code raises
ImportError
before this patch.code
After this patch, there is no more these errors.
Checklist
License
Feel free to contact the maintainers if that's a concern.