Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop JsonSectionPageMapper in Rust API #1224
Develop JsonSectionPageMapper in Rust API #1224
Changes from all commits
859c398
d8c6c5e
b2263ea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I personally love to get access to context.root_path directly, but this is recommended to avoid during detection.
datumaro/src/datumaro/components/format_detection.py
Lines 178 to 179 in 4faaae5
Do you have any objection to use this during detection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That guide is because the methods provided by
context
are usingself._root_path
internally. For example,datumaro/src/datumaro/components/format_detection.py
Lines 354 to 357 in 4faaae5
However,
JsonSectionPageMapper
Rust API has no information forroot_path
. There is no choice but to inject the full pathosp.join(context.root_path, annot_file)
to access the file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, how about other formats with pure Python codes? I just want to hear your opinion.
Frankly speaking, I don't want to avoid the use of
context.root_path
.