Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kaggle data supports #1240

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jan 9, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners January 9, 2024 05:58
@wonjuleee wonjuleee requested review from jihyeonyi and removed request for a team January 9, 2024 05:58
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (b8c6b94) 80.49% compared to head (0b13690) 80.53%.

Files Patch % Lines
src/datumaro/plugins/data_formats/kaggle/base.py 86.97% 17 Missing and 14 partials ⚠️
src/datumaro/plugins/data_formats/mnist_csv.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1240      +/-   ##
===========================================
+ Coverage    80.49%   80.53%   +0.04%     
===========================================
  Files          269      270       +1     
  Lines        29991    30232     +241     
  Branches      5856     5898      +42     
===========================================
+ Hits         24140    24348     +208     
- Misses        4487     4506      +19     
- Partials      1364     1378      +14     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 80.52% <86.36%> (+0.04%) ⬆️
windows-2022_Python-3.8 80.50% <86.36%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jihyeonyi jihyeonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonjuleee wonjuleee merged commit eb44355 into openvinotoolkit:develop Jan 11, 2024
5 checks passed
@yunchu yunchu added this to the 2.0.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants