Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated MediaManager #1262

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Feb 6, 2024

Summary

How to test

No need for the test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Remove MediaManager Remove deprecated MediaManager Feb 6, 2024
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review February 6, 2024 01:29
@vinnamkim vinnamkim requested review from a team as code owners February 6, 2024 01:29
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team February 6, 2024 01:29
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (784e039) 80.54% compared to head (4f34d64) 80.55%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1262   +/-   ##
========================================
  Coverage    80.54%   80.55%           
========================================
  Files          271      270    -1     
  Lines        30438    30406   -32     
  Branches      5930     5925    -5     
========================================
- Hits         24517    24493   -24     
+ Misses        4532     4525    -7     
+ Partials      1389     1388    -1     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 80.54% <100.00%> (+<0.01%) ⬆️
windows-2022_Python-3.8 80.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit 882bb1e into openvinotoolkit:develop Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants