Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image dirs data format streamable #1576

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

itrushkin
Copy link
Contributor

Summary

Geti requires all data formats to be streamable, i. e. generate dataset items on demand.
This PR allows streaming for image dir format.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin requested review from a team as code owners July 29, 2024 06:52
@itrushkin itrushkin requested review from sooahleex and removed request for a team July 29, 2024 06:52
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me, but isn't there any need to add unit tests for this?

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (9bdf8de) to head (1874a9c).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1576      +/-   ##
===========================================
- Coverage    81.03%   81.03%   -0.01%     
===========================================
  Files          276      278       +2     
  Lines        32430    32471      +41     
  Branches      6595     6599       +4     
===========================================
+ Hits         26280    26312      +32     
- Misses        4696     4705       +9     
  Partials      1454     1454              
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <100.00%> (-0.01%) ⬇️
windows-2022_Python-3.10 81.00% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin merged commit 30b1add into openvinotoolkit:develop Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants