Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CamVid format support #55

Merged
merged 9 commits into from
Dec 1, 2020
Merged

Add CamVid format support #55

merged 9 commits into from
Dec 1, 2020

Conversation

yasakova-anastasia
Copy link

Summary

Added support for CamVid format

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

zhiltsov-max
zhiltsov-max suggested changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs some additions.

datumaro/plugins/camvid_format.py Outdated Show resolved Hide resolved
datumaro/plugins/camvid_format.py Show resolved Hide resolved
datumaro/plugins/camvid_format.py Outdated Show resolved Hide resolved
datumaro/plugins/camvid_format.py Outdated Show resolved Hide resolved
datumaro/plugins/camvid_format.py Outdated Show resolved Hide resolved
datumaro/plugins/camvid_format.py Show resolved Hide resolved
tests/test_camvid_format.py Outdated Show resolved Hide resolved
tests/test_camvid_format.py Outdated Show resolved Hide resolved
tests/test_camvid_format.py Outdated Show resolved Hide resolved
tests/test_camvid_format.py Outdated Show resolved Hide resolved
zhiltsov-max
zhiltsov-max approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem I see is that the new format does not support changing colormap, like VOC does. But this can be added later, when needed.

@zhiltsov-max zhiltsov-max merged commit c675cbb into develop Dec 1, 2020
zhiltsov-max pushed a commit that referenced this pull request Dec 11, 2020
@yasakova-anastasia
Release 0.1.4 (#64)
7407d12 
* Relax importer for Pascal VOC dataset (search in subdirectories) (#50)

In some cases developers don't want to specify the exact path to Pascal VOC.
Now you have to specify VOCtrainval_11-May-2012/VOCdevkit/VOC2012/. After the
patch it will be possible to specify VOCtrainval_11-May-2012/.

* Allow missing supercategory in COCO annotations (#54)

Now it is possible to load coco_instances dataset even if the annotation file doesn't have supercategory

* Add CamVid format support (#55)

Co-authored-by: Maxim Zhiltsov <maxim.zhiltsov@intel.com>

* Fix CamVid format (#57)

* Fix ImageNet format

* Fix CamVid format

* ability to install opencv-python-headless instead opencv-python (#62)

Allow to choose `opencv=python-headless` as dependency with `DATUMARO_HEADLESS=1` env. variable when installing

* Release 0.1.4 (#63)

* update version

* update changelog

Co-authored-by: Nikita Manovich <nikita.manovich@intel.com>
Co-authored-by: Anastasia Yasakova <anastasia.yasakova@intel.com>
Co-authored-by: Andrey Zhavoronkov <andrey.zhavoronkov@intel.com>
@yasakova-anastasia yasakova-anastasia deleted the ay/add-camvid branch December 17, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiltsov-max zhiltsov-max zhiltsov-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasakova-anastasia @zhiltsov-max