-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3.1 #726
Release 0.3.1 #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ET.SubElement(size_elem, "depth").text = "" | ||
depth = "" | ||
if item.media.data is not None: | ||
depth = str(item.media.data.shape[-1]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In many cases VOC export is going to take much more time now, because the images have to be loaded. For width and height we often have metainfo in other formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images with coco or other formats are not loaded, so item.media.data is None.
It is run when there are the loaded images. If not, it keeps "".
Any suggestion to set depth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item.media.data
is None only when the image file is not available, but we have metainfo. If you wanted to avoid extra loading, you need to use has_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Then I will update as using has_data you suggested soon. Do you think it should be included in v0.3.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't answer on this question, release logic is out of my responsibility now.
Summary
This PR fix
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.