Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render jupyter-notebook examples in documentation #758

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Nov 7, 2022

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

  • Add jupyter-notebook example rendering to documentation.
  • Related ticket no. 94977.

How to test

Add iframe for notebook examples to documentation as follows.
image

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Base: 84.20% // Head: 84.20% // No change to project coverage 👍

Coverage data is based on head (8217c07) compared to base (725110a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #758   +/-   ##
========================================
  Coverage    84.20%   84.20%           
========================================
  Files          157      157           
  Lines        21855    21855           
  Branches      4779     4779           
========================================
  Hits         18402    18402           
  Misses        2365     2365           
  Partials      1088     1088           
Flag Coverage Δ
macos-10.15_Python-3.10 84.12% <ø> (ø)
macos-10.15_Python-3.7 83.80% <ø> (ø)
macos-10.15_Python-3.8 84.04% <ø> (ø)
macos-10.15_Python-3.9 84.06% <ø> (ø)
ubuntu-20.04_Python-3.10 84.12% <ø> (ø)
ubuntu-20.04_Python-3.7 83.80% <ø> (ø)
ubuntu-20.04_Python-3.8 84.04% <ø> (ø)
ubuntu-20.04_Python-3.9 84.06% <ø> (+<0.01%) ⬆️
windows-2019_Python-3.10 84.14% <ø> (ø)
windows-2019_Python-3.7 83.82% <ø> (ø)
windows-2019_Python-3.8 84.05% <ø> (ø)
windows-2019_Python-3.9 84.07% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonjuleee wonjuleee merged commit 66e33aa into openvinotoolkit:develop Nov 10, 2022
wonjuleee pushed a commit to wonjuleee/datumaro that referenced this pull request Nov 28, 2022
* Render jupyter-notebook in documentation

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Add CHANGELOG.md

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Fix Bandits and whitespace

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants