Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter notebook for transform #759

Merged
merged 8 commits into from
Nov 15, 2022

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Nov 10, 2022

Summary

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@74842de). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #759   +/-   ##
==========================================
  Coverage           ?   84.20%           
==========================================
  Files              ?      157           
  Lines              ?    21855           
  Branches           ?     4779           
==========================================
  Hits               ?    18403           
  Misses             ?     2365           
  Partials           ?     1087           
Flag Coverage Δ
macos-10.15_Python-3.10 84.12% <0.00%> (?)
ubuntu-20.04_Python-3.10 84.12% <0.00%> (?)
ubuntu-20.04_Python-3.7 83.80% <0.00%> (?)
ubuntu-20.04_Python-3.8 84.04% <0.00%> (?)
ubuntu-20.04_Python-3.9 84.05% <0.00%> (?)
windows-2019_Python-3.10 84.14% <0.00%> (?)
windows-2019_Python-3.7 83.82% <0.00%> (?)
windows-2019_Python-3.8 84.06% <0.00%> (?)
windows-2019_Python-3.9 84.06% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -0,0 +1,3444 @@
{
Copy link
Contributor

@vinnamkim vinnamkim Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of sample throguh <- typo


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I corrected

@@ -0,0 +1,3444 @@
{
Copy link
Contributor

@vinnamkim vinnamkim Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to do it using dataset.transform() like the others? For example, val_dataset.transform("split", task="segmentation", splits=splits)


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as following your comment. Thanks.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit ac90e81 into openvinotoolkit:develop Nov 15, 2022
wonjuleee added a commit to wonjuleee/datumaro that referenced this pull request Nov 28, 2022
* add notebooks for transform

* add nootebook example for transform api

* update changelog

* update notebook

* pylint resolve

* correct a notebook for transform api

* correct a notebook for transform api

* correct typo
@wonjuleee wonjuleee deleted the nb_transform branch December 8, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants