Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get list of subsets and support only Image media in visualizer #768

Merged
merged 8 commits into from
Nov 24, 2022

Conversation

sooahleex
Copy link
Contributor

Summary

  • Support list of subsets to show data of all subsets
  • Support only Image media type in Visualizer
    • For brats_dataset, MultiframeImage media type is used

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Base: 84.64% // Head: 84.20% // Decreases project coverage by -0.44% ⚠️

Coverage data is based on head (06a27e0) compared to base (c5327b3).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #768      +/-   ##
===========================================
- Coverage    84.64%   84.20%   -0.45%     
===========================================
  Files          157      157              
  Lines        21925    21931       +6     
  Branches      4804     4806       +2     
===========================================
- Hits         18558    18466      -92     
- Misses        2263     2369     +106     
+ Partials      1104     1096       -8     
Flag Coverage Δ
macos-10.15_Python-3.10 84.11% <50.00%> (?)
macos-10.15_Python-3.7 83.79% <50.00%> (-0.02%) ⬇️
macos-10.15_Python-3.8 84.03% <50.00%> (-0.46%) ⬇️
macos-10.15_Python-3.9 84.05% <50.00%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.10 84.13% <50.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.7 83.79% <50.00%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.8 84.03% <50.00%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.9 84.05% <50.00%> (-0.02%) ⬇️
windows-2019_Python-3.10 84.13% <50.00%> (?)
windows-2019_Python-3.7 83.81% <50.00%> (-0.02%) ⬇️
windows-2019_Python-3.8 84.04% <50.00%> (?)
windows-2019_Python-3.9 84.06% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/visualizer.py 92.89% <50.00%> (-1.88%) ⬇️
datumaro/plugins/synthetic_data/utils.py 17.94% <0.00%> (-64.11%) ⬇️
datumaro/plugins/synthetic_data/image_generator.py 69.93% <0.00%> (-12.89%) ⬇️
datumaro/components/operations.py 84.40% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sooahleex sooahleex changed the title Update visualizer Get list of subsets and support only Image media in visualizer Nov 24, 2022
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sooahleex sooahleex merged commit eabce02 into openvinotoolkit:develop Nov 24, 2022
@sooahleex sooahleex deleted the visualizer_update branch November 24, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants