Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised bandit exclusion comments #904

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Mar 30, 2023

Summary

Revised some comments for excluding to the report of bandit.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5aebe49) 78.87% compared to head (0efc131) 78.87%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #904   +/-   ##
========================================
  Coverage    78.87%   78.87%           
========================================
  Files          204      204           
  Lines        25020    25020           
  Branches      5031     5031           
========================================
  Hits         19735    19735           
  Misses        4152     4152           
  Partials      1133     1133           
Flag Coverage Δ
macos-11_Python-3.8 77.86% <100.00%> (ø)
ubuntu-20.04_Python-3.8 78.86% <100.00%> (ø)
windows-2019_Python-3.8 78.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/filter.py 92.27% <100.00%> (ø)
datumaro/components/project.py 79.18% <100.00%> (ø)
datumaro/plugins/data_formats/cifar.py 87.17% <100.00%> (ø)
datumaro/util/pickle_util.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yunchu yunchu merged commit fd5aa10 into openvinotoolkit:develop Apr 10, 2023
@yunchu yunchu deleted the revise-nosec-comments branch April 10, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants