Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tfds:uc_merced and tfds:eurosat download #914

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 5, 2023

Summary

  • Ticket no. 107273
  • Add tfds:uc_merced and tfds:eurosat download
  • These datasets will be used for the merge tutorial

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added FEATURE New feature & functionality ENHANCE Enhancement of existing features and removed FEATURE New feature & functionality labels Apr 5, 2023
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 5, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review April 5, 2023 01:27
@vinnamkim vinnamkim requested review from a team as code owners April 5, 2023 01:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (edfd106) 78.86% compared to head (79b3f1b) 78.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #914      +/-   ##
===========================================
- Coverage    78.86%   78.85%   -0.01%     
===========================================
  Files          215      215              
  Lines        25200    25202       +2     
  Branches      5043     5043              
===========================================
  Hits         19873    19873              
- Misses        4192     4193       +1     
- Partials      1135     1136       +1     
Flag Coverage Δ
macos-11_Python-3.8 ?
ubuntu-20.04_Python-3.8 78.85% <100.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 78.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/extractor_tfds.py 95.85% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

JihwanEom
JihwanEom previously approved these changes Apr 5, 2023
sooahleex
sooahleex previously approved these changes Apr 5, 2023
@vinnamkim vinnamkim dismissed stale reviews from sooahleex and JihwanEom via 43cbaae April 5, 2023 08:16
wonjuleee
wonjuleee previously approved these changes Apr 6, 2023
@vinnamkim vinnamkim merged commit 8cf70ba into openvinotoolkit:develop Apr 7, 2023
@vinnamkim vinnamkim deleted the feature/download-uc-merced-and-eurosat branch April 7, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants