Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviate "detect-format" to "detect" for prettifying #951

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Apr 19, 2023

Summary

  • Abbreviate "detect-format" to "detect" for prettifying
  • This is because "detect-format" is only one who has hyphen in itself.

How to test

I corrected the existing CLI tests for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.2.0 milestone Apr 19, 2023
@vinnamkim vinnamkim marked this pull request as ready for review April 19, 2023 01:16
@vinnamkim vinnamkim requested review from a team as code owners April 19, 2023 01:16
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (ef6ab36) 78.70% compared to head (f841115) 78.69%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #951      +/-   ##
==================================================
- Coverage           78.70%   78.69%   -0.02%     
==================================================
  Files                 232      232              
  Lines               26420    26420              
  Branches             5258     5258              
==================================================
- Hits                20795    20792       -3     
- Misses               4400     4401       +1     
- Partials             1225     1227       +2     
Flag Coverage Δ
macos-11_Python-3.8 77.73% <ø> (ø)
ubuntu-20.04_Python-3.8 78.69% <ø> (ø)
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/cli/commands/__init__.py 80.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@cih9088 cih9088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you modify this as well for completeness?
I have no idea how one generated this thing though.

@vinnamkim
Copy link
Contributor Author

Would you modify this as well for completeness? I have no idea how one generated this thing though.

I'm working on this in another WIP PR.

@vinnamkim vinnamkim merged commit 5d872d2 into openvinotoolkit:releases/1.2.0 Apr 19, 2023
@vinnamkim vinnamkim deleted the refactor/abbreviate-detect-format-to-detect branch April 19, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants