Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich stack trace while importing dataset to improve user experience #992

Merged
merged 12 commits into from
May 9, 2023

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented May 8, 2023

Summary

  • Sorted detection results to make it consistent if something went wrong
  • Added a verbose error output with what and where Datumaro tried to import
  • Changed to consume ctx for all data formats supported officially to lift up one level of stack trace
  • Narrowed down exception type for verbosity

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added the user experience Questions about our products or things to improve user experience label May 8, 2023
@cih9088 cih9088 added this to the 1.3.0 milestone May 8, 2023
@cih9088 cih9088 requested review from a team as code owners May 8, 2023 05:53
@cih9088 cih9088 added the ENHANCE Enhancement of existing features label May 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2023

Codecov Report

Patch coverage: 73.28% and project coverage change: +0.03 🎉

Comparison is base (12ddca4) 78.72% compared to head (1d75570) 78.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #992      +/-   ##
===========================================
+ Coverage    78.72%   78.75%   +0.03%     
===========================================
  Files          233      233              
  Lines        26505    26626     +121     
  Branches      5273     5283      +10     
===========================================
+ Hits         20866    20970     +104     
- Misses        4413     4424      +11     
- Partials      1226     1232       +6     
Flag Coverage Δ
macos-11_Python-3.8 77.78% <73.28%> (+0.04%) ⬆️
ubuntu-20.04_Python-3.8 78.72% <73.28%> (+0.02%) ⬆️
windows-2019_Python-3.8 78.63% <73.28%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/yolo/exporter.py 71.64% <0.00%> (ø)
.../plugins/data_formats/mapillary_vistas/importer.py 75.92% <33.33%> (+0.45%) ⬆️
...ro/plugins/data_formats/sly_pointcloud/exporter.py 82.35% <33.33%> (ø)
...atumaro/plugins/data_formats/kitti_raw/exporter.py 85.76% <40.00%> (ø)
datumaro/plugins/data_formats/celeba/celeba.py 74.53% <43.75%> (+0.48%) ⬆️
datumaro/components/importer.py 89.76% <50.00%> (ø)
datumaro/plugins/data_formats/coco/importer.py 95.41% <50.00%> (+0.04%) ⬆️
datumaro/plugins/data_formats/icdar/exporter.py 88.57% <50.00%> (ø)
datumaro/plugins/data_formats/kitti/exporter.py 77.93% <50.00%> (ø)
datumaro/plugins/data_formats/kitti/importer.py 85.24% <50.00%> (+0.24%) ⬆️
... and 53 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 force-pushed the feature/user-friendly-error branch from 5fc23c7 to a39b16d Compare May 8, 2023 08:10
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a minor comment.

datumaro/components/dataset.py Show resolved Hide resolved
@cih9088 cih9088 merged commit 38bbf0c into openvinotoolkit:develop May 9, 2023
@cih9088 cih9088 deleted the feature/user-friendly-error branch May 9, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features user experience Questions about our products or things to improve user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants