Fix unstable graphs using TfLite Tensors #2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
reviewed
Nov 17, 2023
atobiszei
force-pushed
the
atobisze_tflite_fix
branch
2 times, most recently
from
8386d37
to
2e443a7
Compare
dkalinowski
reviewed
Nov 27, 2023
| SPDLOG_DEBUG("Mediapipe failed to execute: {}", absMessage); | ||
| return Status(StatusCode::MEDIAPIPE_EXECUTION_ERROR, absMessage); | ||
| } | ||
| MP_RETURN_ON_FAIL(graph.CloseAllPacketSources(), "graph close all packet sources", StatusCode::MEDIAPIPE_GRAPH_CLOSE_INPUT_STREAM_ERROR); |
There was a problem hiding this comment.
Why 2x closing all packet sources?
dkalinowski
approved these changes
Nov 27, 2023
atobiszei
force-pushed
the
atobisze_tflite_fix
branch
from
2e443a7
to
8da271b
Compare
atobiszei
force-pushed
the
atobisze_tflite_fix
branch
from
8da271b
to
721d8ef
Compare
psakamoori
pushed a commit
to psakamoori/model_server
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:CVS-125140