Use bazel to build aws-sdk-cpp #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atobiszei
force-pushed
the
atobisze_bump_cloud_aws
branch
from
fd9e321
to
5e2d6f1
Compare
rasapala
approved these changes
Feb 26, 2024
atobiszei
commented
Feb 27, 2024
tf.patch
Outdated
There was a problem hiding this comment.
This is leftover copy of file already present in external/.
mzegla
reviewed
Feb 27, 2024
src/BUILD
Outdated
| constraint_value(constraint_setting = "linux_distribution_family", name = "debian") # like Ubuntu | ||
|
|
||
| create_config_settings() | ||
| #create_config_settings() |
Comment on lines
+864
to
+867
| "@aws-sdk-cpp//:aws-sdk-cpp_ubuntu", | ||
| ], | ||
| "//:redhat_build": [ | ||
| "@aws-sdk-cpp//:aws-sdk-cpp_redhat", |
There was a problem hiding this comment.
how about using dashes in whole target name?
There was a problem hiding this comment.
IMO it actually distinguish target from some separate gimicks for ubuntu/redhat.
src/BUILD
Outdated
| @@ -878,6 +877,9 @@ cc_library( # make ovms_lib dependent, use share doptions | |||
| local_defines = COMMON_LOCAL_DEFINES, | |||
| copts = COPTS_ADJUSTED, | |||
| linkopts = LINKOPTS_ADJUSTED, | |||
| # Check if needed TODO | |||
There was a problem hiding this comment.
Do we still need to do something here?
| recursive_init_submodules = True, | ||
| # https://github.com/bazelbuild/bazel/issues/374 | ||
| # issues with ASCI handling of file_test.c *xample file.txt in bazel | ||
| patch_cmds = ["find . -name '*xample.txt' -delete"], |
There was a problem hiding this comment.
Because bazel cannot handle non ascii names:
aws-sdk-cpp/crt/aws-crt-cpp/crt/aws-c-common/tests/resources/Å Éxample.txt
I would have the full name here but I cannot ;)
openvinotoolkit/mediapipe#65 |
mzegla
approved these changes
Feb 27, 2024
psakamoori
pushed a commit
to psakamoori/model_server
that referenced
this pull request
Apr 2, 2024
Additionally bump aws-sdk-cpp version to 1.11.279 Encountered issues with bazel. Non ASCII filenames don't work inside bazel. Workaround is to remove test file from aws-sdk-cpp. bazelbuild/bazel#374 Building with rules_foreign cmake doesn't work with parallel builds. This is something we could optimize later, for now hardcode some low value: bazel-contrib/rules_foreign_cc#329 On Redhat to properly build targets we now have to add: --//:distro=redhat By default distro is set to ubuntu. This is workaround for not bazel not being able to differentiate between the two. There is difference in aws-sdk-cpp static libraries location after build. Ideally we should find how to use select on aws-sdk-cpp repo BUILD file which would rely on main repo flag, but I didn't find way to support it there. JIRA:CVS-130367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally bump aws-sdk-cpp version to 1.11.279
Encountered issues with bazel. Non ASCII filenames don't work inside bazel. Workaround is to remove test file from aws-sdk-cpp.
bazelbuild/bazel#374
Building with rules_foreign cmake doesn't work with parallel builds. This is something we could optimize later, for now hardcode some low value:
bazel-contrib/rules_foreign_cc#329
On Redhat to properly build targets we now have to add:
--//:distro=redhatBy default distro is set to ubuntu. This is workaround for not bazel not being able to differentiate between the two. There is difference in aws-sdk-cpp static libraries location after build. Ideally we should find how to use select on aws-sdk-cpp repo BUILD file which would rely on main repo flag, but I didn't find way to support it there.