Documentation updates - rt_info in client/x/kserve-api #2779
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porlows1
force-pushed
the
doc-demos-val-update
branch
from
d7aee3a
to
c30a06b
Compare
porlows1
force-pushed
the
doc-demos-val-update
branch
from
c30a06b
to
23f53a1
Compare
ngrozae
approved these changes
Oct 31, 2024
dtrawins
reviewed
Oct 31, 2024
docs/llm/quickstart.md
Outdated
| @@ -38,7 +38,7 @@ node: { | |||
| node_options: { | |||
| [type.googleapis.com / mediapipe.LLMCalculatorOptions]: { | |||
| models_path: "./", | |||
| plugin_config: '{"KV_CACHE_PRECISION": "u8", "DYNAMIC_QUANTIZATION_GROUP_SIZE": "32"}', | |||
| plugin_config: '\''{"KV_CACHE_PRECISION": "u8", "DYNAMIC_QUANTIZATION_GROUP_SIZE": "32"}'\'', | |||
There was a problem hiding this comment.
why this is changed? It will not work in my opinion.
There was a problem hiding this comment.
Escape character was added inside echo '<json_content>' command.
Is ' character required in output file?
This character was used in graph.pbtxt in continuous batching demo: https://github.com/openvinotoolkit/model_server/blob/main/demos/continuous_batching/graph.pbtxt (line 19)
Without ' character we get an error:
[libprotobuf ERROR external/com_google_protobuf/src/google/protobuf/text_format.cc:335] Error parsing text-format mediapipe.CalculatorGraphConfig: 20:26: Expected string, got: {
porlows1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Fixes in documentation related to:
https://jira.devtools.intel.com/browse/CVS-156333 - added rt_info
https://jira.devtools.intel.com/browse/CVS-156334 - added rt_info
Passing tests:
http://validationreports.sclab.intel.com:8001/reports/build_number_report?test_session_build_number=ovms-c_uat_build_and_test_23f53a1b879cc7c6_28&environment=clx6-ubuntu22-uat
🧪 Checklist