Skip to content

smaller default cache size #3738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

smaller default cache size #3738

wants to merge 1 commit into from
+3 −3

Conversation

@dtrawins
Copy link
Collaborator

@dtrawins dtrawins commented Oct 28, 2025

🛠 Summary

Reduced default cache size to avoid OOM on hosts with limited RAM

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

@dtrawins dtrawins requested review from atobiszei and mzegla October 28, 2025 15:48
mzegla
mzegla reviewed Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@mzegla mzegla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a change in llm_calculator.proto as well.
Additionally, doesn't our demo with benchmarking need an update to mention somewhere that with default deployment cache size might be too small for throughput oriented benchmark?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzegla mzegla mzegla left review comments

@atobiszei atobiszei Awaiting requested review from atobiszei

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dtrawins @mzegla