Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust codecov.yml #2067

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

vshampor
Copy link
Contributor

Changes

Makes Codecov wait for 2 reports being uploaded before printing a comment, since we have both onnx and common precommits submitting coverage reports now via GH action runs.

Reason for changes

Currently the common precommit finishes much faster than the ONNX, and Codecov posts coverage based off that run before waiting for the ONNX precommit to finish, which is necessarily lower and confusing.

Related tickets

N/A

Tests

N/A

@vshampor vshampor requested a review from a team as a code owner August 18, 2023 16:35
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #2067 (59da322) into develop (a1074e7) will increase coverage by 3.12%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2067      +/-   ##
===========================================
+ Coverage    32.93%   36.06%   +3.12%     
===========================================
  Files          476      476              
  Lines        42391    42391              
===========================================
+ Hits         13961    15287    +1326     
+ Misses       28430    27104    -1326     

see 43 files with indirect coverage changes

@vshampor vshampor merged commit 046ded3 into openvinotoolkit:develop Aug 21, 2023
6 checks passed
daniil-lyakhov pushed a commit to daniil-lyakhov/nncf that referenced this pull request Aug 25, 2023
### Changes
Makes Codecov wait for 2 reports being uploaded before printing a
comment, since we have both onnx and common precommits submitting
coverage reports now via GH action runs.

### Reason for changes
Currently the common precommit finishes much faster than the ONNX, and
Codecov posts coverage based off that run before waiting for the ONNX
precommit to finish, which is necessarily lower and confusing.

### Related tickets
N/A

### Tests
N/A
andreyanufr pushed a commit to andreyanufr/nncf that referenced this pull request Sep 12, 2023
### Changes
Makes Codecov wait for 2 reports being uploaded before printing a
comment, since we have both onnx and common precommits submitting
coverage reports now via GH action runs.

### Reason for changes
Currently the common precommit finishes much faster than the ONNX, and
Codecov posts coverage based off that run before waiting for the ONNX
precommit to finish, which is necessarily lower and confusing.

### Related tickets
N/A

### Tests
N/A
@vshampor vshampor deleted the coverage_improvements branch January 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant