Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry coverage extension #3039

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Telemetry coverage extension #3039

merged 8 commits into from
Jan 8, 2025

Conversation

KodiaqQ
Copy link
Collaborator

@KodiaqQ KodiaqQ commented Oct 25, 2024 •
edited
Loading

Changes

  • Extended coverage for telemetry.

Reason for changes

  • Telemetry update.

Related tickets

  • 154833

Tests

  • TBD

New categories/events are introduced:

Method Event category Event name Event label
nncf.strip nncf_tf,nncf_pt,nncf_pt_fx,nncf_onnx,nncf_ov function_call nncf.strip
nncf.data....generate_text_data nncf function_call nncf.data.generate_text_data
nncf.torch....wrap_model nncf_pt function_call nncf.torch.wrap_model
nncf.torch....load_from_config nncf_pt function_call nncf.torch.load_from_config
nncf.torch....get_config nncf_pt function_call nncf.torch.nncf_network.NNCFNetwork.get_config

@KodiaqQ KodiaqQ marked this pull request as ready for review October 25, 2024 10:23
@KodiaqQ KodiaqQ requested a review from a team as a code owner October 25, 2024 10:23
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common labels Oct 25, 2024
alexsu52
alexsu52 reviewed Oct 30, 2024
View reviewed changes
nncf/common/strip.py Outdated Show resolved Hide resolved
nncf/telemetry/events.py Outdated Show resolved Hide resolved
nncf/data/generators.py Show resolved Hide resolved
nncf/common/telemetry_extractors.py Outdated Show resolved Hide resolved
@KodiaqQ KodiaqQ marked this pull request as draft December 9, 2024 08:01
@github-actions github-actions bot added the API Public API-impacting changes label Dec 9, 2024
@KodiaqQ KodiaqQ requested a review from alexsu52 December 9, 2024 12:06
@KodiaqQ KodiaqQ marked this pull request as ready for review December 9, 2024 12:06
@KodiaqQ
Copy link
Collaborator Author

KodiaqQ commented Dec 17, 2024

Do we need this, @alexsu52, @MaximProshin?

alexsu52
alexsu52 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaximProshin
MaximProshin approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@MaximProshin MaximProshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit 801e5af into openvinotoolkit:develop Jan 8, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popovaan popovaan popovaan left review comments

@MaximProshin MaximProshin MaximProshin approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common NNCF PT Pull requests that updates NNCF PyTorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KodiaqQ @alexsu52 @MaximProshin @popovaan