-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT2] MinMax #3166
Open
AlexanderDokuchaev
wants to merge
16
commits into
openvinotoolkit:develop
Choose a base branch
from
AlexanderDokuchaev:ad/pt2_minmax
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[PT2] MinMax #3166
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1b2bf15
init
AlexanderDokuchaev a4366ab
Merge branch 'develop' into ad/pt2_minmax
AlexanderDokuchaev 516c716
efficientnet_pytorch==0.7.1
AlexanderDokuchaev ab0ceec
addict
AlexanderDokuchaev af939a4
dot
AlexanderDokuchaev 873a1df
mypy
AlexanderDokuchaev 6c62051
c
AlexanderDokuchaev 3301f7b
Merge branch 'develop' into ad/pt2_minmax
AlexanderDokuchaev c3c809c
mypy
AlexanderDokuchaev cc9e0fc
f
AlexanderDokuchaev b18c9a2
none
AlexanderDokuchaev 40466e2
no cache for gpu
AlexanderDokuchaev 656ca73
p
AlexanderDokuchaev 5d038c2
revert
AlexanderDokuchaev 1f8ce90
Merge branch 'develop' into ad/pt2_minmax
AlexanderDokuchaev 8693917
rename
AlexanderDokuchaev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Copyright (c) 2024 Intel Corporation | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from typing import List, Optional | ||
|
||
from torch import nn | ||
|
||
from nncf.common.graph.transformations.commands import Command | ||
from nncf.common.graph.transformations.commands import TransformationType | ||
from nncf.experimental.torch2.function_hook.hook_storage import RemovableHookHandle | ||
from nncf.torch.graph.transformations.commands import PTTargetPoint | ||
|
||
|
||
class PT2InsertionCommand(Command): | ||
""" | ||
Insertion operation to the models. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
target_points: List[PTTargetPoint], | ||
hook_module: nn.Module, | ||
*, | ||
handle_storage: Optional[List[RemovableHookHandle]] = None, | ||
): | ||
super().__init__(TransformationType.INSERT) | ||
self.target_points = target_points | ||
self.hook_module = hook_module | ||
self.handle_storage = handle_storage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Copyright (c) 2024 Intel Corporation | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from typing import Any, Dict, Tuple, Union | ||
|
||
import torch | ||
|
||
from nncf.common.engine import Engine | ||
from nncf.experimental.torch2.function_hook.nncf_graph.nncf_graph_builder import GraphModelWrapper | ||
|
||
|
||
class PT2Engine(Engine): | ||
""" | ||
Engine for the Pytorch backend. | ||
""" | ||
|
||
def __init__(self, model: GraphModelWrapper): | ||
""" | ||
Constructor. | ||
|
||
:param model: Pytorch module to infer. | ||
""" | ||
|
||
self._model = model.model | ||
self._model.eval() | ||
|
||
def infer(self, input_data: Union[torch.Tensor, Tuple[torch.Tensor], Dict[str, torch.Tensor]]) -> Any: | ||
""" | ||
Runs Torch model on the provided input. | ||
|
||
:param input_data: Inputs for the model. | ||
:return: Model outputs. | ||
""" | ||
|
||
if isinstance(input_data, dict): | ||
return self._model(**input_data) | ||
if isinstance(input_data, tuple): | ||
return self._model(*input_data) | ||
return self._model(input_data) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse PTEngine as it done for the TorchFX backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can , but what a reason?
I have try to keep one way dependence torch2 from torch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was asked to remove the
PTFXEngine
by @alexsu52, await the same comment from him