Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Enable check for some files in nncf/common #3171

Merged
merged 14 commits into from
Jan 8, 2025
Merged

[mypy] Enable check for some files in nncf/common #3171

merged 14 commits into from
Jan 8, 2025

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Dec 30, 2024 •
edited
Loading

Changes

  1. Enable mypy check for:

    • nncf/api
    • nncf/common/*.py (exlude some files with many error)
    • nncf/common/initialization

  2. Remove extension_is_loading_info_log - torch specific function that used only ones.

@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner December 30, 2024 10:29
@github-actions github-actions bot added NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common labels Dec 30, 2024
@AlexanderDokuchaev AlexanderDokuchaev changed the title [mypy[ Enable check for some files in nncf/common [mypy] Enable check for some files in nncf/common Dec 30, 2024
@github-actions github-actions bot added the API Public API-impacting changes label Dec 30, 2024
@github-actions github-actions bot added the NNCF TF Pull requests that updates NNCF TensorFlow label Dec 30, 2024
alexsu52
alexsu52 reviewed Jan 6, 2025
View reviewed changes
nncf/api/compression.py Show resolved Hide resolved
nncf/common/scopes.py Outdated Show resolved Hide resolved
nncf/tensorflow/sparsity/rb/algorithm.py Show resolved Hide resolved
alexsu52
alexsu52 reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexsu52
alexsu52 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@alexsu52 alexsu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsu52 alexsu52 merged commit e14460d into openvinotoolkit:develop Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common NNCF PT Pull requests that updates NNCF PyTorch NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderDokuchaev @alexsu52