Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving parser for 'crossroad_camera_demo' #3359

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

ieliz
Copy link
Contributor

@ieliz ieliz commented Mar 14, 2022

Changing parser for 'crossroad_camera_demo'.
Aligning code style of parser according to OMZ. requirements(indentations, the naming of arguments, etc).
Changing test cases and README.md.
As example used PR: #3131

@ieliz ieliz requested a review from Wovchena March 14, 2022 09:22
@ieliz ieliz marked this pull request as draft March 14, 2022 11:16
@ieliz ieliz marked this pull request as ready for review March 16, 2022 14:12
@ieliz
Copy link
Contributor Author

ieliz commented Mar 16, 2022

Jenkins please retry a build

5 similar comments
@ieliz
Copy link
Contributor Author

ieliz commented Mar 22, 2022

Jenkins please retry a build

@vladimir-dudnik
Copy link
Contributor

Jenkins please retry a build

@ieliz
Copy link
Contributor Author

ieliz commented Mar 25, 2022

Jenkins please retry a build

@ieliz
Copy link
Contributor Author

ieliz commented Mar 25, 2022

Jenkins please retry a build

@vladimir-dudnik
Copy link
Contributor

Jenkins please retry a build

<< "\n\t[--show] ([--noshow]) " << show_msg
<< "\n\t[ -t <NUMBER>] " << t_msg
<< "\n\t[--tpr <NUMBER>] " << tpr_msg
<< "\n\t[ -u <MONITORS>] " << u_msg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<< "\n\t[ -u <MONITORS>] " << u_msg
<< "\n\t[ -u <MONITORS>] " << u_msg

}
videoWriter.write(frame);
if (FLAGS_show) {
cv::imshow("Detection results", frame);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cv::imshow("Detection results", frame);
cv::imshow(argv[0], frame);

videoWriter.write(frame);
if (FLAGS_show) {
cv::imshow("Detection results", frame);
const int key = cv::waitKey(1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const int key = cv::waitKey(1);
const int key = cv::pollKey();

if (FLAGS_show) {
cv::imshow("Detection results", frame);
const int key = cv::waitKey(1);
if (27 == key) // Esc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Q and q in addition to Esc

Handle pause keys

Comment on lines 73 to 74
"(as it is returned from the detection network, may vary from one network to another). "
"Default is 1";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"(as it is returned from the detection network, may vary from one network to another). "
"Default is 1";
"(as it is returned from the detection network, may vary from one network to another). "
"Default is 1";

DEFINE_double(tpr, 0.7, tpr_msg);

constexpr char u_msg[] = "resource utilization graphs. "
"c - average CPU load, d - load distribution over cores, m - memory usage, h - hide";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"c - average CPU load, d - load distribution over cores, m - memory usage, h - hide";
"c - average CPU load, d - load distribution over cores, m - memory usage, h - hide";

@openmodelzooci
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants