Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code style for cpp model api demos #3435

Merged
merged 6 commits into from
Apr 1, 2022
Merged

Fix code style for cpp model api demos #3435

merged 6 commits into from
Apr 1, 2022

Conversation

ivikhrev
Copy link

@ivikhrev ivikhrev commented Mar 31, 2022 •
edited
Loading

Continue of #3418

@ivikhrev ivikhrev force-pushed the fix-code-style-model-api-demos branch from d1d25fd to 954c962 Compare March 31, 2022 16:41
@ivikhrev ivikhrev force-pushed the fix-code-style-model-api-demos branch from 954c962 to 0d99138 Compare March 31, 2022 16:53
@ivikhrev ivikhrev requested a review from Wovchena March 31, 2022 16:53
Wovchena
Wovchena requested changes Mar 31, 2022
View reviewed changes
demos/classification_benchmark_demo/cpp/grid_mat.hpp Outdated Show resolved Hide resolved
demos/classification_benchmark_demo/cpp/grid_mat.hpp Outdated Show resolved Hide resolved
demos/classification_benchmark_demo/cpp/grid_mat.hpp Outdated Show resolved Hide resolved
demos/classification_benchmark_demo/cpp/grid_mat.hpp Outdated Show resolved Hide resolved
demos/common/cpp/models/src/detection_model_faceboxes.cpp Outdated Show resolved Hide resolved
demos/common/cpp/models/src/detection_model_faceboxes.cpp Outdated Show resolved Hide resolved
demos/common/cpp/models/src/detection_model_faceboxes.cpp Outdated Show resolved Hide resolved
demos/common/cpp/models/src/detection_model_faceboxes.cpp Outdated Show resolved Hide resolved
@ivikhrev
Copy link
Author

@jkamelin python precommit fails. Is it connected with #3424 ?

20:15:39  + ./venv/bin/omz_info_dumper --list src/demos/3d_segmentation_demo/python/models.lst
20:15:39  Traceback (most recent call last):
20:15:39    File "./venv/bin/omz_info_dumper", line 5, in <module>
20:15:39      from openvino.model_zoo.omz_info_dumper import main
20:15:39    File "/home/jenkins/workspace/omz/precommit/python_demos_ubuntu18/venv/lib/python3.6/site-packages/openvino/model_zoo/omz_info_dumper.py", line 21, in <module>
20:15:39      from openvino.model_zoo import _configuration, _common
20:15:39    File "/home/jenkins/workspace/omz/precommit/python_demos_ubuntu18/venv/lib/python3.6/site-packages/openvino/model_zoo/_configuration.py", line 23, in <module>
20:15:39      from openvino.model_zoo import _common
20:15:39    File "/home/jenkins/workspace/omz/precommit/python_demos_ubuntu18/venv/lib/python3.6/site-packages/openvino/model_zoo/_common.py", line 23, in <module>
20:15:39      from . import __version__
20:15:39  ImportError: cannot import name '__version__'

@ivikhrev @Wovchena
Apply suggestions from code review
8b04078 
Co-authored-by: Zlobin Vladimir <vladimir.zlobin@intel.com>
@jkamelin
Copy link
Contributor

@jkamelin python precommit fails. Is it connected with #3424 ?

20:15:39  + ./venv/bin/omz_info_dumper --list src/demos/3d_segmentation_demo/python/models.lst
20:15:39  Traceback (most recent call last):
20:15:39    File "./venv/bin/omz_info_dumper", line 5, in <module>
20:15:39      from openvino.model_zoo.omz_info_dumper import main
20:15:39    File "/home/jenkins/workspace/omz/precommit/python_demos_ubuntu18/venv/lib/python3.6/site-packages/openvino/model_zoo/omz_info_dumper.py", line 21, in <module>
20:15:39      from openvino.model_zoo import _configuration, _common
20:15:39    File "/home/jenkins/workspace/omz/precommit/python_demos_ubuntu18/venv/lib/python3.6/site-packages/openvino/model_zoo/_configuration.py", line 23, in <module>
20:15:39      from openvino.model_zoo import _common
20:15:39    File "/home/jenkins/workspace/omz/precommit/python_demos_ubuntu18/venv/lib/python3.6/site-packages/openvino/model_zoo/_common.py", line 23, in <module>
20:15:39      from . import __version__
20:15:39  ImportError: cannot import name '__version__'

Fixed with #3436

@ivikhrev ivikhrev marked this pull request as ready for review March 31, 2022 18:09
@ivikhrev
Copy link
Author

Jenkins please retry a build

@ivikhrev ivikhrev mentioned this pull request Mar 31, 2022
Open
@Wovchena Wovchena merged commit 3109f65 into openvinotoolkit:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wovchena Wovchena Wovchena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivikhrev @jkamelin @Wovchena