[Image generation] Non public API changes for image generation #1146
+170
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: text to image
Wovchena
reviewed
Nov 5, 2024
| OPENVINO_ASSERT(shape[0] == 1, "Batch size must be 1"); | ||
| shape[1] /= 2; | ||
|
|
||
| m_mean = ov::Tensor(parameters.get_element_type(), shape, parameters.data()); |
There was a problem hiding this comment.
m_mean doesn't own parameters's data. If parameters is destroyed after DiagonalGaussianDistribution construction, sample()would read garbage from mean_data. You are just lucky to call sample() immediately.
| } | ||
|
|
||
| ov::Tensor sample(std::shared_ptr<Generator> generator) const { | ||
| ov::Tensor rand_tensor = generator->randn_tensor(m_mean.get_shape()); |
There was a problem hiding this comment.
Suggested change
| ov::Tensor rand_tensor = generator->randn_tensor(m_mean.get_shape()); | |
| ov::Tensor rand_tensor = generator->randn_tensor(m_mean.get_shape()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, LCM image to image generation works correctly.
Public API will be later