Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test precommit segfault #471

Closed

Conversation

pavel-esir
Copy link
Contributor

No description provided.

pavel-esir and others added 25 commits May 24, 2024 11:33
* greedy-sampling

* greedy sampling

* greedy sampling

* Update greedy_sampling.hpp

don't transform the logits during top_p

* Update greedy_causal_lm.cpp

* format

* early exit for arg_max

* Update default parameters

* Add multinomial sampling

* Remove unused hpp

* Reuse util functions

* Apply review comments

* Merge config

* Use size_t for iteration

* apply comments

* Move rand gen to class member

* Apply comments

* Add multinomial sampling

* Remove path

* Apply comments

* Fix merge

---------

Co-authored-by: wenyi5608 <93560477+wenyi5608@users.noreply.github.com>
* enable

* libtbb-dev

* move

* slash

* install

* core_genai_dev

* remove export

* rreorganaise components

* add SOVERSION, and requirements-build.txt

* repalce SKBUILD with EXCLUDE_FROM_ALL because the effect is the same

* fix NAMELINK_COMPONENT

* remove extraline

* add soft restrictions

* Fix build to unblock packaging

* improve naming

* install samples

* remove quotes

* use main target name because an alias can't be specified in cmake --target

* define CMAKE_BUILD_PARALLEL_LEVEL

* Ensure ./requirements-build.txt won't outdate

* Use ./requirements-build.txt in python lib build

* Add missing &&

* Test Debug

* add matrix for windows_genai_package

* openvino_tokenizers from form

* update openvino_tokenizers

* update openvino_tokenizers

* update openvino_tokenizers

* revert openvino_tokenizers

* tokenizers from fork

* update tokenizers

* centos7_2024.2.0.dev

* copy target

* revert tokenizers

* reapply useful changes

* copy so only

* Update tokenizers, centos7_2024.2.0.dev

* single thread

* ubuntu22

* nightyl

* --pre --extra-index-url

* update tokenizers

* space

* move --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

* release tokenizers

* merge

* downgrade tokenizers

* downgrade

* two steps

* downgrade tokenizers

* dont setupvars

* source

* fix

* submodule

* releases/2024/2 tokenizers

* fix-2

* rebase

* use make

* comment

* CMAKE_GENERATOR=Unix Makefiles

* update openvino

* space

* optimum-cli from fork

* different commit

* from branch

* remove exrtra-index for SD

* reorder pip install

* revert unwanted changes

* Ubuntu-22

* openvino_tokenizers~=2024.2.0.0

* remove -pre . --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

* upgrade to prerelease

* revert requirements.txt

* remove --pre, setupvars

* get openvino_tokenizers._ext_path

* take release pybind, fix soversion, and tokenizers folder

* spelling

* dont copy libs

* put ov_tokenizers_path back

* GENAI_BUILD_DIR=../../build
* enable

* libtbb-dev

* move

* slash

* install

* core_genai_dev

* remove export

* rreorganaise components

* add SOVERSION, and requirements-build.txt

* repalce SKBUILD with EXCLUDE_FROM_ALL because the effect is the same

* fix NAMELINK_COMPONENT

* remove extraline

* add soft restrictions

* Fix build to unblock packaging

* improve naming

* install samples

* remove quotes

* use main target name because an alias can't be specified in cmake --target

* define CMAKE_BUILD_PARALLEL_LEVEL

* Ensure ./requirements-build.txt won't outdate

* Use ./requirements-build.txt in python lib build

* Add missing &&

* Test Debug

* add matrix for windows_genai_package

* openvino_tokenizers from form

* update openvino_tokenizers

* update openvino_tokenizers

* update openvino_tokenizers

* revert openvino_tokenizers

* tokenizers from fork

* update tokenizers

* centos7_2024.2.0.dev

* copy target

* revert tokenizers

* reapply useful changes

* copy so only

* Update tokenizers, centos7_2024.2.0.dev

* single thread

* ubuntu22

* nightyl

* --pre --extra-index-url

* update tokenizers

* space

* move --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

* release tokenizers

* merge

* downgrade tokenizers

* downgrade

* two steps

* downgrade tokenizers

* dont setupvars

* source

* fix

* submodule

* releases/2024/2 tokenizers

* fix-2

* rebase

* use make

* comment

* CMAKE_GENERATOR=Unix Makefiles

* update openvino

* space

* optimum-cli from fork

* different commit

* from branch

* remove exrtra-index for SD

* reorder pip install

* revert unwanted changes

* Ubuntu-22

* openvino_tokenizers~=2024.2.0.0

* remove -pre . --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

* upgrade to prerelease

* revert requirements.txt

* remove --pre, setupvars

* get openvino_tokenizers._ext_path

* take release pybind, fix soversion, and tokenizers folder

* spelling

* dont copy libs

* put ov_tokenizers_path back

* GENAI_BUILD_DIR=../../build

* Add extension near to genai library

* include openvino/util/file_util.hpp

* get_absolute_file_path

* remove namepsace

* #    include <limits.h>

* more than one .

* till next dot

* _ext_path

* -1

* +1

* +1

* path

* ext name

* with_openvino_tokenizers

* char

* revert test

* tokenizers from form

* update fork

* lib

* fix cherry-pick

* update fork

* dont spoil source dir

* Generator expressions to disable appending a per-configuration subdirectory

* remove versions

* fix path

* try

* try

* verbose

* spelling

* rename file

* remove build.tool-args

* Release

* dont speciify targets

* revert 81ec069
* Add callback binding

* put models back

* Update list_test_models.py

---------

Co-authored-by: Pavel Esir <pavel.esir@gmail.com>
* Add streamer binding

* remove todo
fix genai env manager on Win;
fix failing multibatch tests;
* Add macos test for genai package workflow

* Skip other os tests

* Remove dependency installation

* Add build dependencies

* Fix link to archive

* Skip copying libcore_tokenizers.so for macos

* Remove additional brew packages

* Revert "Remove additional brew packages"

This reverts commit f7f1b18.

* Add concurrency to genai workflows

* Add initial job for test on macos

* Unskip ubuntu & windows jobs for genai package workflow

* Update links to macos archives

* Update macos workflows

* Set cmake generator for macos workflow

* Keep only one verbose arg

* Switch macos archive installation to rc2
* Return eos_token from beam search algo

* sourt beams per prompt

* Filter eos_tokens before decoding

* update tokenizers

* Update tokenizers

* Remove eos check from streamer
* Fix noise images generated for '--num' > 1 in Stable Diffusion sample (openvinotoolkit#441)

Fixes openvinotoolkit#405

* update optimum intel commit in llm bench (openvinotoolkit#444)

* Fix an attempt to add a string value to a numerical value (openvinotoolkit#447)

* output no hook data warning when it is text gen model (openvinotoolkit#449)

* Fix md5 hash for env that does not support usedforsecurity arg (openvinotoolkit#445)

I got an error running benchmarking on my working machine (python3.8,
ubuntu20) due to unsupported args for hashlib.
```
[ ERROR ] An exception occurred
[ INFO ] Traceback (most recent call last):
  File "benchmark.py", line 532, in main
    iter_data_list, pretrain_time = CASE_TO_BENCH[model_args['use_case']](model_path, framework, args.device, model_args, args.num_iters)
  File "benchmark.py", line 194, in run_text_generation_benchmark
    run_text_generation(input_text, num, model, tokenizer, args, iter_data_list, warmup_md5, prompt_idx, bench_hook, model_precision, proc_id)
  File "benchmark.py", line 131, in run_text_generation
    result_md5_list.append(hashlib.md5(result_text.encode(), usedforsecurity=False).hexdigest())
TypeError: openssl_md5() takes at most 1 argument (2 given)
```
Based on this [StackOverflow
issue](https://stackoverflow.com/questions/54717862/how-do-i-know-if-the-usedforsecurity-flag-is-supported-by-hashlib-md5),
not all clients support this argument and usage hashlib.new("md5") vs
hashlib.md5 should be safe for usage in both cases

* fix path based configuration (openvinotoolkit#456)

* Revert "Force to generate "inference count" tokens" (openvinotoolkit#455)

Reverts openvinotoolkit#289 to unblock the release.
Since it causes the performance regression of some models. (WIP to
investigate the reason)

* enable

* libtbb-dev

* move

* slash

* install

* core_genai_dev

* remove export

* rreorganaise components

* add SOVERSION, and requirements-build.txt

* repalce SKBUILD with EXCLUDE_FROM_ALL because the effect is the same

* fix NAMELINK_COMPONENT

* remove extraline

* add soft restrictions

* Fix build to unblock packaging

* verify beam search 1st token optimization (openvinotoolkit#426)

The minimum version of transformers to get 1st and 2nd tokens latency is
v4.40-release.

* Output median min and avg values to csv (openvinotoolkit#450)

Co-authored-by: Chen Peter <peter.chen@intel.com>

* improve naming

* install samples

* remove quotes

* use main target name because an alias can't be specified in cmake --target

* define CMAKE_BUILD_PARALLEL_LEVEL

* Ensure ./requirements-build.txt won't outdate

* Use ./requirements-build.txt in python lib build

* Add missing &&

* Test Debug

* add matrix for windows_genai_package

* openvino_tokenizers from form

* update openvino_tokenizers

* update openvino_tokenizers

* update openvino_tokenizers

* revert openvino_tokenizers

* tokenizers from fork

* update tokenizers

* centos7_2024.2.0.dev

* copy target

* revert tokenizers

* reapply useful changes

* copy so only

* Update tokenizers, centos7_2024.2.0.dev

* single thread

* ubuntu22

* nightyl

* --pre --extra-index-url

* update tokenizers

* space

* move --pre --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

* release tokenizers

* merge

* downgrade tokenizers

* downgrade

* two steps

* downgrade tokenizers

* dont setupvars

* source

* fix

* submodule

* releases/2024/2 tokenizers

* fix-2

* rebase

* use make

* comment

* CMAKE_GENERATOR=Unix Makefiles

* update openvino

* space

* optimum-cli from fork

* different commit

* from branch

* remove exrtra-index for SD

* reorder pip install

* revert unwanted changes

* Ubuntu-22

* openvino_tokenizers~=2024.2.0.0

* remove -pre . --extra-index-url https://storage.openvinotoolkit.org/simple/wheels/nightly

* upgrade to prerelease

* revert requirements.txt

* remove --pre, setupvars

* get openvino_tokenizers._ext_path

* take release pybind, fix soversion, and tokenizers folder

* spelling

* dont copy libs

* put ov_tokenizers_path back

* GENAI_BUILD_DIR=../../build

* Add extension near to genai library

* include openvino/util/file_util.hpp

* get_absolute_file_path

* remove namepsace

* #    include <limits.h>

* more than one .

* till next dot

* _ext_path

* -1

* +1

* +1

* path

* ext name

* with_openvino_tokenizers

* char

* revert test

* tokenizers from form

* update fork

* lib

* fix cherry-pick

* update fork

* dont spoil source dir

* Generator expressions to disable appending a per-configuration subdirectory

* remove versions

* fix path

* try

* try

* verbose

* spelling

* rename file

* remove build.tool-args

* Release

* dont speciify targets

* revert 81ec069

* Update tests

* No rule to make target package

* skip step

* test tokenizers are loaded

* CPU

* dont test Debug

* retrigger

* minor

* 16-cores

* retrigger

* retrigger

* retrigger

* -x

* str

* less verbose

* less verbose

* less

* less

* more

* no cache

* conflicts

* cache

* export

* cached save

* rename

* rename

* 16-cores

* no larg

* save memory

* retrigger

* predownload

* comment

* export name

* exports

* supress

* revert

* test_operator_wit_callback_batch_fail

* run test_beam_search_decoding only

* test_decoding

* remove Phi

* all

* add return bool to streamer to stop generation

* add return bool to streamer to stop generation

* add return bool to streamer to stop generation

* add return bool to streamer to stop generation

* dont test StopCriteria.EARLY because it fails

* update

* remove sudo apt-get install libtbb-dev

* submodule from fork

* update submodule

* update submodule

* update submodule

* update submodule

* set upstream submodule, add copyright headers, shorten commands

* space

* dir link

* retrigger

* update

* skip

* test

* put optimum-intel[openvino] back

* flake8

* flake8

* optimum[openvino]==1.20.0

* update tests/python_tests/requirements.txt

---------

Co-authored-by: Yaroslav Tarkan <yaroslav.tarkan@intel.com>
Co-authored-by: Ekaterina Aidova <ekaterina.aidova@intel.com>
Co-authored-by: guozhong wang <guozhong.wang@intel.com>
Co-authored-by: Chen Peter <peter.chen@intel.com>
Co-authored-by: Pavel Esir <pavel.esir@intel.com>
fix ignore_eos
fix batched detokenization
add generation config validation
removed CPU and redundant getting KV cache
@github-actions github-actions bot added the category: llm_bench Label for tool/llm_bench folder label Jun 5, 2024
@pavel-esir pavel-esir deleted the generate_pipeline_test branch June 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: llm_bench Label for tool/llm_bench folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants