Add CB naive chat #644
Merged
Add CB naive chat #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That allows LLMPipeline to create ContinuousBatchingPipeline as a backend. There's also a constructor accepting ireq, which can be used if the model was already transformed appropriately for ContinuousBatchingPipeline. But it feels it's going to be misleading and it simpler just to throw if such constructor is called with ContinuousBatchingPipeline backend.
…LMPipeline' into use-CB-as-backend
…-similar-to-LLMPipeline
…LMPipeline' into use-CB-as-backend
Wovchena
requested review from
pavel-esir,
iefode,
mzegla,
dkalinowski and
popovaan
Merged
|
build_jenkins |
mzegla
reviewed
Jul 24, 2024
Comment on lines
+281
to
+282
| if (streamer_ptr) { | ||
| streamer_ptr->end(); |
There was a problem hiding this comment.
Why do we continue to execute this function when streamer is used? Output has already been read and pushed to streamer in above while loop.
There was a problem hiding this comment.
That's just API. We document that end() is called in the end. One possible use case to let the streamer to flush the output.
Closed
andrei-kochin
approved these changes
Jul 24, 2024
Merged
via the queue into
openvinotoolkit:releases/2024/3
with commit Jul 24, 2024
f9e45e1
31 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.