Simplified partial preemption algorithm. #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
popovaan
commented
Aug 2, 2024
popovaan
commented
- Simplified partial preemption algorithm for groups with multiple sequences.
- Removed dividing into single sequence and multiple sequence path.
ilya-lavrenov
approved these changes
Aug 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| @@ -399,15 +364,13 @@ class BlockManager { | |||
| return block_table[block_idx]->is_free(); | |||
| } | |||
|
|
|||
| void free_sequence_partially_single_runnning_sequence(size_t seq_id, size_t block_num) { | |||
| // this method is applicable only for groups with single sequences | |||
| void free_sequence_partially(size_t seq_id, size_t block_num) { | |||
There was a problem hiding this comment.
here during multiple sequences case, we suppose that we can free the same amount of blocks for each sequence, which can be wrong for beam search case...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.