Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable genai_package tests for debug build #832

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+22 −18
Open

[CI] Enable genai_package tests for debug build #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc719b0
Enable multinomial_causal_lm python samples tests in debug mode for l…
yatarkan Sep 13, 2024
6a76c25
Build and run samples with cmd for genai_package windows tests
yatarkan Sep 13, 2024
029e018
Bump tokenizers submodule to latest master
yatarkan Sep 13, 2024
27e7794
Merge branch 'master' into yt/enable-genai-package-debug-tests
yatarkan Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ jobs:
timeout 25s ${{ github.workspace }}/s\ pace/samples_bin/greedy_causal_lm ./TinyLlama-1.1B-Chat-v1.0/ ""

- name: Test python samples (multinomial_causal_lm)
if: ${{ 'Release' == matrix.build-type }} # Python bindings can be built in Release only
run: |
source ${OV_INSTALL_DIR}/setupvars.sh
timeout 25s ${OV_INSTALL_DIR}/samples/python/multinomial_causal_lm/multinomial_causal_lm.py ./TinyLlama-1.1B-Chat-v1.0/ 0
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,6 @@ jobs:
timeout 25s ${{ github.workspace }}/s\ pace/samples_bin/greedy_causal_lm ./TinyLlama-1.1B-Chat-v1.0/ ""

- name: Test python samples (multinomial_causal_lm)
if: ${{ 'Release' == matrix.build-type }} # Python bindings can be built in Release only
run: |
source ${OV_INSTALL_DIR}/setupvars.sh
timeout 25s ${OV_INSTALL_DIR}/samples/python/multinomial_causal_lm/multinomial_causal_lm.py ./TinyLlama-1.1B-Chat-v1.0/ 0
Expand Down
36 changes: 21 additions & 15 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,45 +295,51 @@ jobs:
uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0

- name: Build genai libs
shell: cmd
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -S ./ -B ./build/
cmake --build ./build/ --config ${{ matrix.build-type }} --target package -j
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
cmake -DCMAKE_BUILD_TYPE=${{ matrix.build-type }} -S .\ -B .\build
cmake --build .\build --config ${{ matrix.build-type }} --target package -j

- name: Build and Install dependencies
shell: cmd
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
python -m pip install ./thirdparty/openvino_tokenizers/[transformers] --find-links ${env:OV_INSTALL_DIR}/tools
python -m pip install --upgrade-strategy eager -r ./samples/requirements.txt --find-links ${env:OV_INSTALL_DIR}/tools
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
python -m pip install .\thirdparty\openvino_tokenizers\[transformers] --find-links ${env:OV_INSTALL_DIR}\tools
python -m pip install --upgrade-strategy eager -r .\samples\requirements.txt --find-links ${env:OV_INSTALL_DIR}\tools
optimum-cli export openvino --trust-remote-code --weight-format fp16 --model TinyLlama/TinyLlama-1.1B-Chat-v1.0 TinyLlama-1.1B-Chat-v1.0

- name: Install samples
shell: cmd
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
cmake --install ./build/ --config ${{ matrix.build-type }} --prefix ${{ env.OV_INSTALL_DIR }}
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you revert the powershell?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #832 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no output for Test C++ samples (greedy_causal_lm) step on Windows, but it exists for other OSes.
The suggestion was that there might be some linking issues on Windows but PowerShell command succeeds or does not print anything. I tried to switch to cmd to check it.

cmake --install .\build\ --config ${{ matrix.build-type }} --prefix ${{ env.OV_INSTALL_DIR }}

- name: Build samples (Release)
if: ${{ 'Release' == matrix.build-type }} # build_samples enforces Release build
shell: cmd
run: |
& ${{ env.OV_INSTALL_DIR }}\samples\cpp\build_samples.ps1 -i ${{ github.workspace }}/samples_install
call ${{ env.OV_INSTALL_DIR }}\samples\cpp\build_samples_msvc.bat -i ${{ github.workspace }}\samples_install

- name: Build samples (Debug)
if: ${{ 'Release' != matrix.build-type }}
shell: cmd
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
cmake -DCMAKE_BUILD_TYPE= -S ./ov/samples/cpp/ -B "samples build"
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
cmake -DCMAKE_BUILD_TYPE= -S .\ov\samples\cpp\ -B "samples build"
cmake --build "samples build" --config ${{ matrix.build-type }} -j
cmake --install "samples build" --config ${{ matrix.build-type }} --component samples_bin --prefix samples_install

- name: Test C++ samples (greedy_causal_lm)
shell: cmd
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
Start-Process -FilePath "${{ github.workspace }}/samples_install/samples_bin/greedy_causal_lm.exe" -ArgumentList "TinyLlama-1.1B-Chat-v1.0 ''"
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
start "" "${{ github.workspace }}\samples_install\samples_bin\greedy_causal_lm.exe" "TinyLlama-1.1B-Chat-v1.0" ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I don't see any output from this sample. Is it run?


- name: Test python samples (multinomial_causal_lm)
if: ${{ 'Release' == matrix.build-type }} # Python bindings can be built in Release only
shell: cmd
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
python ${{ env.OV_INSTALL_DIR }}\samples\python\multinomial_causal_lm\multinomial_causal_lm.py TinyLlama-1.1B-Chat-v1.0 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have debug python API for OpenVINO


Overall_Status:
Expand Down
2 changes: 1 addition & 1 deletion thirdparty/openvino_tokenizers
Open in desktop
Submodule openvino_tokenizers updated 6 files
+10 −9 src/CMakeLists.txt
+5 −5 src/bpe_tokenizer.cpp
+14 −0 src/patches/fast_tokenizers.patch
+1 −1 src/regex_split.hpp
+4 −4 src/utf8_validate.cpp
+12 −6 src/utils.cpp
Loading