【PaddlePaddle Hackathon 3】Add Paddle where_index operator #12437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asthestarsfalll
changed the title
Asthestarsfalll
commented
Aug 5, 2022
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_where_index.py
Show resolved
Hide resolved
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_where_index.py
Show resolved
Hide resolved
liubo-intel
reviewed
Aug 15, 2022
There was a problem hiding this comment.
Hi, @Asthestarsfalll : thanks for contribution of this Paddle OP conversion. Have added some suggestions for rank 1 and Boolean type test case coverage. Other parts looks good to me.
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_where_index.py
Outdated
Show resolved
Hide resolved
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_where_index.py
Show resolved
Hide resolved
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_where_index.py
Show resolved
Hide resolved
liubo-intel
added
category: PDPD FE
liubo-intel
approved these changes
Aug 19, 2022
|
Hi, @ceciliapeng2011 : do you have any other comments about this PR? if none, could you please help merge it? tks. |
ceciliapeng2011
requested changes
Sep 1, 2022
| from save_model import saveModel | ||
| import sys | ||
| import paddle | ||
| from paddle.fluid.layer_helper import LayerHelper |
There was a problem hiding this comment.
Can you use paddle 2.1 api instead of fluid which is obsolete after paddle 1.8 to build unit tests?
There was a problem hiding this comment.
done.
But there is a little diference between paddle.nonzero and where_index.
With the parameter as_tuple=True, paddle.nonzero will convert the output to tuple.
ceciliapeng2011
approved these changes
Sep 13, 2022
ilyachur
approved these changes
Sep 13, 2022
ilyachur
reviewed
Sep 13, 2022
Co-authored-by: Ilya Churaev <ilyachur@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
add where_index operation in Paddle front end
Reference:
https://github.com/PaddlePaddle/Paddle2ONNX/blob/7e6ce45ebb4c108d7b602abb1858e2218f559b00/paddle2onnx/legacy/op_mapper/search.py
https://github.com/openvinotoolkit/openvino/blob/master/docs/ops/condition/NonZero_3.md
Not find document of where_index
uni-test passed