-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyOV] Enable Python 3.10 on Azure CI #12578
[PyOV] Enable Python 3.10 on Azure CI #12578
Conversation
…into drop_python3.6
…into drop_python3.6
…into drop_python3.6
…into drop_python3.6
tar -xzf Python-"$PYTHON_VERSION".tgz | ||
cd Python-"$PYTHON_VERSION" || exit | ||
./configure --enable-optimizations --prefix=/usr/local --enable-shared LDFLAGS="-Wl,-rpath /usr/local/lib" | ||
make python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and maybe in other places we are just wasting machine time with building python each time.
I still suppose we need to enable python 3.10 only on Jenkins, while on Azure we should use default python version for the system (for Windows we can install 3.10 since Windows does not have python by default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered in an internal channel.
Please, have a look at pip conflicts issue:
And resolve merge conflicts. |
The pip conflicts issue is fixed by bumping NNCF commit on CI, the PR is currently waiting for review and merge. I'll resolve conflicts later to not waste CI's time. |
attrs==19.1.0 | ||
pytest==4.0.1; python_version < '3.10' | ||
pytest==7.2.0; python_version >= '3.10' | ||
py>=1.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure that py
package requires to install separately?
as I know pytest 7.2.0 removes dependency on it
pytest-dev/pytest#10396
P.S. this package has vulnerability issue, from product perspective, it can lead to problems if we will require it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to support a range of pytest versions due to multiple different Python versions used (and other repositories' dependencies). The reason it's added is there were CIs failing due to this package not being installed in the environment. Adding it helped with the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eaidova BTW it is still open how to score this problem and other additional packages are still using py
if you look at some comments like: pytest-dev/py#287 (comment) or here tox-dev/tox#2524
It is still on-going effort to drop it everywhere and some of checks still show the issue.
I think we should be dealing with it in separate issue - not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not insist, just highlight potential problem which these changes bring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However if py
is a problem, project will face it eventually, even without this change. This package is already a dependency of others... probably a new task is coming.
Thanks for noticing it!
Details:
openvino_dev
wheel on Python 3.10Tickets: