Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xuejun/set element type private #22722

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Xuejun/set element type private #22722

merged 9 commits into from
Feb 8, 2024

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented Feb 8, 2024 •
edited by itikhono
Loading

Details:

  • Removes get_ov_tensor_legacy_name(); set_ov_tensor_legacy_name(); set_tensor_type; set_element_type; functions from public API and deprecates them.
  • Refactoring

Tickets:

@zhaixuejun1993
[Deprecated API] Move api set_element_type() & set_tensor_type() from…
4b3acb2 
… public to private

Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
@zhaixuejun1993
clean code
bee4417 
Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
@zhaixuejun1993
Revert "clean code"
1fc07ad 
This reverts commit bee4417.
@zhaixuejun1993
Revert "[Deprecated API] Move api set_element_type() & set_tensor_typ…
3839b60 
…e() from public to private"

This reverts commit 4b3acb2.
@zhaixuejun1993
Fix review comment
9501ed4 
Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
@zhaixuejun1993
fix review comments
9dfc44b 
Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
@zhaixuejun1993
fix format issue
1cf81e8 
Signed-off-by: Zhai, Xuejun <xuejun.zhai@intel.com>
@ilya-lavrenov ilya-lavrenov added this to the 2024.0 milestone Feb 8, 2024
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners February 8, 2024 08:55
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations category: ONNX FE OpenVINO ONNX FrontEnd category: CPP API OpenVINO CPP API bindings labels Feb 8, 2024
@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner February 8, 2024 09:12
@ilya-lavrenov ilya-lavrenov force-pushed the xuejun/set_element_type_private branch 2 times, most recently from c3c3ab8 to abadcdc Compare February 8, 2024 09:29
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners February 8, 2024 09:29
@ilya-lavrenov ilya-lavrenov requested review from akopytko and removed request for a team February 8, 2024 09:29
@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: docs_snippets OpenVINO docs snippets (docs/snippets) labels Feb 8, 2024
@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner February 8, 2024 09:32
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Feb 8, 2024
This was referenced Feb 8, 2024
Closed
Closed
Closed
@p-durandin p-durandin added this pull request to the merge queue Feb 8, 2024
Merged via the queue into openvinotoolkit:master with commit 0215d27 Feb 8, 2024
106 checks passed
@ilya-lavrenov ilya-lavrenov deleted the xuejun/set_element_type_private branch August 8, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@p-durandin p-durandin p-durandin approved these changes

@vurusovs vurusovs vurusovs approved these changes

@zhaixuejun1993 zhaixuejun1993 zhaixuejun1993 approved these changes

@itikhono itikhono itikhono approved these changes

@akopytko akopytko Awaiting requested review from akopytko akopytko is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees

@itikhono itikhono

@jane-intel jane-intel

@praasz praasz

Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: docs_snippets OpenVINO docs snippets (docs/snippets) category: IE Tests OpenVINO Test: plugins and common category: ONNX FE OpenVINO ONNX FrontEnd category: transformations OpenVINO Runtime library - Transformations github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
2024.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ilya-lavrenov @itikhono @zhaixuejun1993 @vurusovs @p-durandin @praasz @jane-intel