Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] POC for sycl ref FC compressed kernel #23534

Closed
wants to merge 3 commits into from
Closed

[GPU] POC for sycl ref FC compressed kernel #23534

wants to merge 3 commits into from

Conversation

vladimir-paramuzov
Copy link
Contributor

Details:

  • This POC shows how to add a sycl kernel in GPU plugin. As an example, compressed reference FC sycl kernel is used.

Tickets:

  • 134090

@github-actions github-actions bot added category: GPU OpenVINO GPU plugin category: build OpenVINO cmake script / infra category: docs OpenVINO documentation labels Mar 19, 2024
This was referenced Apr 24, 2024
Merged
Merged
ilya-lavrenov added a commit that referenced this pull request Apr 27, 2024
@ilya-lavrenov
Fixed case when users explicitly pass different gcc ABI via cxx flags (…
3b0d201 
…#24274)

### Details:
- Should help with
conan-io/conan-center-index#23754
 - Taken from #23534
github-merge-queue bot pushed a commit that referenced this pull request Apr 27, 2024
@ilya-lavrenov
Intel compiler support (#24217)
c121e89 
### Details:
 - Initial version of Intel compiler support
 - Only Linux is covered
- Current PR is a prerequisite for
#23534
ilya-lavrenov
ilya-lavrenov reviewed Apr 27, 2024
View reviewed changes
src/plugins/intel_gpu/CMakeLists.txt Outdated
@@ -61,6 +65,7 @@ target_compile_options(${TARGET_NAME} PRIVATE
$<$<CONFIG:Release>:$<IF:$<CXX_COMPILER_ID:MSVC>,/Os,-Os>>)

target_link_libraries(${TARGET_NAME} PRIVATE openvino_intel_gpu_graph openvino::pugixml)
target_link_options(${TARGET_NAME} PUBLIC -static-intel)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed, because it's handled in common cmake code

src/plugins/intel_gpu/CMakeLists.txt Outdated
@@ -44,6 +47,7 @@ include(thirdparty/cmake/rapidjson.cmake)
if(CMAKE_COMPILER_IS_GNUCXX)
ov_add_compiler_flags(-Werror)
endif()
ov_add_compiler_flags(-Rno-debug-disables-optimization)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required? looks like it works without this flag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not. IIRC, I added it to avoid huge amount of warnings in debug build

src/plugins/intel_gpu/src/graph/CMakeLists.txt
@@ -64,6 +68,6 @@ ov_install_static_lib(${TARGET_NAME} ${OV_CPACK_COMP_CORE})
if(ENABLE_SSE42)
ov_sse42_optimization_flags(sse4_2_flags)
set_source_files_properties(impls/cpu/detection_output.cpp PROPERTIES
COMPILE_FLAGS "${sse4_2_flags}"
COMPILE_FLAGS "${sse4_2_flags} -xSSE4.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled by ov_sse42_optimization_flags, which learned Intel LLVM as well

src/plugins/intel_gpu/tests/CMakeLists.txt Outdated
@@ -3,5 +3,6 @@
#

add_subdirectory(common)
add_subdirectory(unit)
# Unit tests doesn't link for some reason with icpx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, perform the following steps to compile unit tests:

  1. Merge with latest master
  2. Add the following cmake lines to unit tests cmake:
if(OV_COMPILER_IS_INTEL_LLVM)
  set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld")
  string(REPLACE "-pie" "" CMAKE_EXE_LINKER_FLAGS_RELEASE "${CMAKE_EXE_LINKER_FLAGS_RELEASE}")
endif()

alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@ilya-lavrenov @alvoron
Fixed case when users explicitly pass different gcc ABI via cxx flags (…
ee941f7 
…openvinotoolkit#24274)

### Details:
- Should help with
conan-io/conan-center-index#23754
 - Taken from openvinotoolkit#23534
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@ilya-lavrenov @alvoron
Intel compiler support (openvinotoolkit#24217)
34609b2 
### Details:
 - Initial version of Intel compiler support
 - Only Linux is covered
- Current PR is a prerequisite for
openvinotoolkit#23534
@github-actions GitHub Actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label May 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: docs OpenVINO documentation category: GPU OpenVINO GPU plugin do_not_merge Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimir-paramuzov @ilya-lavrenov