Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OV JS] Remove extra assets from tests #25712

Merged
merged 19 commits into from
Aug 21, 2024
Merged

[OV JS] Remove extra assets from tests #25712

merged 19 commits into from
Aug 21, 2024

Conversation

almilosz
Copy link
Contributor

@almilosz almilosz commented Jul 24, 2024 •
edited
Loading

Details:

  • Remove testing models from repository
  • Add setup.js script that will be called once to download testing models
  • Before running the suite check if model is downloaded, add top describe to *.test.js files

Notes:

Currently there is no global setup file for native node test runner as in other test runner e.g. jest

Tickets:

@github-actions github-actions bot added the category: JS API OpenVino JS API Bindings label Jul 24, 2024
@almilosz almilosz marked this pull request as ready for review August 20, 2024 07:36
@almilosz almilosz requested a review from a team as a code owner August 20, 2024 07:36
vishniakov-nikolai
vishniakov-nikolai reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code style remarks. Also propose create test_models dir on fly, do not use src/bindings/js/node/tests/unit/test_models/.gitkeep

src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/scripts/download_runtime.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/basic.test.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
@vishniakov-nikolai vishniakov-nikolai added this to the 2024.4 milestone Aug 20, 2024
vishniakov-nikolai
vishniakov-nikolai approved these changes Aug 21, 2024
View reviewed changes
src/bindings/js/node/tests/unit/compiled_model.test.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/compiled_model.test.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/model.test.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/pre_post_processor.test.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/read_model.test.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/setup.js Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/utils.js Outdated Show resolved Hide resolved
src/bindings/js/node/tests/unit/infer_request.test.js Outdated Show resolved Hide resolved
vishniakov-nikolai
vishniakov-nikolai approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@vishniakov-nikolai vishniakov-nikolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! LGTM

@almilosz almilosz added this pull request to the merge queue Aug 21, 2024
Merged via the queue into openvinotoolkit:master with commit a07e2bc Aug 21, 2024
136 checks passed
@almilosz almilosz deleted the almilosz/remove-assests branch August 21, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishniakov-nikolai vishniakov-nikolai vishniakov-nikolai approved these changes

Assignees
No one assigned
Labels
category: JS API OpenVino JS API Bindings
Projects
None yet
Milestone
2024.4
Development

Successfully merging this pull request may close these issues.
2 participants
@almilosz @vishniakov-nikolai