OV file path migration to std lib interface #26595
Open
+212
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_files, join_paths
barnasm1
added
category: Core
github-actions
bot
added
category: IE Tests
src/common/util/CMakeLists.txt
Outdated
| @@ -37,7 +37,9 @@ add_library(${TARGET_NAME} STATIC ${LIBRARY_SRC} ${PUBLIC_HEADERS}) | |||
| add_library(openvino::util ALIAS ${TARGET_NAME}) | |||
| set_target_properties(${TARGET_NAME} PROPERTIES EXPORT_NAME util) | |||
|
|
|||
| target_link_libraries(${TARGET_NAME} PRIVATE ${CMAKE_DL_LIBS} PUBLIC openvino::pugixml) | |||
| # TODO: make lib linkage portable e.g.: openvino/src/bindings/python/thirdparty/pybind11/tests/CMakeLists.txt | |||
| target_link_libraries(${TARGET_NAME} PRIVATE ${CMAKE_DL_LIBS} PUBLIC openvino::pugixml stdc++fs ) | |||
There was a problem hiding this comment.
does it required new C++ standard ?
There was a problem hiding this comment.
No, the feature will be C++11 compatible. Where possible I plan to use experimental part of std filesystem lib and in reference tests for custom implementation. I would like the interface to be as close to std as possible to smoothly adapt future fixups to the newer CPP standard.
barnasm1
requested review from
kblaszczak-intel
and removed request for
a team
github-actions
bot
added
the
category: docs_snippets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: