Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Allowed fusing i8/u8 fc with eltwise in dynamic case #26646

Merged
merged 4 commits into from
Sep 20, 2024
Merged

[GPU] Allowed fusing i8/u8 fc with eltwise in dynamic case #26646

merged 4 commits into from
Sep 20, 2024

Conversation

Lyamin-Roman
Copy link
Contributor

Details:

  • When creating an unfused subgraph, old weights dependencies are used, which leads to name conflicts
  • Using unfuse logic leads to significant performance drop, added ability to use fully_connected_gpu_imad kernel for eltwise fusing

@Lyamin-Roman Lyamin-Roman added the category: GPU OpenVINO GPU plugin label Sep 17, 2024
@Lyamin-Roman Lyamin-Roman requested review from a team as code owners September 17, 2024 22:24
@yeonbok
Copy link
Contributor

yeonbok commented Sep 18, 2024

LGTM except the suggested change

@yeonbok yeonbok closed this Sep 18, 2024
@yeonbok yeonbok reopened this Sep 18, 2024
@e-ddykim
Copy link
Contributor

I also prepared a PR to fix the unfusing logic. (#26563)
I checked that your new unit tests are passed with my PR.
Could you let me know about the original issue?

@Lyamin-Roman Lyamin-Roman changed the title [GPU] Added update of weights id in primitives for correct unfusion work [GPU] Allowed fusing i8/u8 fc with eltwise in dynamic case Sep 19, 2024
@yeonbok yeonbok added this pull request to the merge queue Sep 20, 2024
Merged via the queue into openvinotoolkit:master with commit f99b327 Sep 20, 2024
136 checks passed
@Lyamin-Roman Lyamin-Roman deleted the unfusion_fix branch September 20, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-ddykim e-ddykim e-ddykim left review comments

@dnkurek dnkurek dnkurek approved these changes

@yeonbok yeonbok yeonbok approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lyamin-Roman @yeonbok @e-ddykim @dnkurek